Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing request_id type to OauthTokenResponse #481

Closed
wants to merge 1 commit into from
Closed

fix: add missing request_id type to OauthTokenResponse #481

wants to merge 1 commit into from
+1 −0

Conversation

MohammedEsafi
Copy link

This pull request addresses the addition of a missing request_id type in the OauthTokenResponse TypeScript definition

Changes Made

Added TypeScript type definition for request_id in the OauthTokenResponse

Example Oauth Response

{
  "access_token": ...,
  "token_type": ...,
  "bot_id": ...,
  "workspace_name": "Mohammed Esafi",
  "workspace_icon": null,
  "workspace_id": ...,
  "owner": ...,
  "duplicated_template_id": ...,
  "request_id": "ae17caab-bad9-424f-98c7-e00daa2a1317"
}

@CLAassistant
Copy link

CLAassistant commented Dec 25, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@MohammedEsafi MohammedEsafi force-pushed the fix/oauth-type-missing-request-id branch 2 times, most recently from 069ae27 to 1ab14d4 Compare January 16, 2024 19:17
@christinewa
Copy link
Contributor

Hey, thanks for opening this PR. We're doing some git history cleanup and need to close the PR as it'll become invalid. Afterwards, please reclone the repo and you can reopen the PR. Thanks for your patience and sincere apologies for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MohammedEsafi @CLAassistant @christinewa